Check if :appsec setting is present before accessing it in remote component
#2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
changed the title
:appsec setting is enabled before accessing it in remote component:appsec setting is present before accessing it in remote component
marcotc
approved these changes
May 16, 2023
GustavoCaso
deleted the
fix-appsec-component-not-loaded-error-on-remote-component
branch
ivoanjo
reviewed
May 17, 2023
Comment on lines
25
to
+26
| def register(settings) | ||
| if settings.appsec.enabled | ||
| if settings.respond_to?(:appsec) && settings.appsec.enabled |
There was a problem hiding this comment.
To be honest, this is why I'm not a big fan of patching behavior into core classes, especially conditionally; it makes is a bit hard to reason about what's there or what's not and only really gives the illusion of things being separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a regression previously fixed #2677.
Since the introduction of remote components, the CI configuration for some projects has been broken.
The issue comes from the remote component checking
appsecsettings. In the context of CI, most users do not load appsec, which is causing issues. This PR fixes itMotivation
Additional Notes
How to test the change?
CI