[APPSEC-9935] AppSec, make sure to use service entry span. #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
GustavoCaso
force-pushed
the
appsec-make-sure-tags-are-added-to-service-entry-span
branch
from
2245f92
to
a8cbb46
Compare
GustavoCaso
changed the title
GustavoCaso
changed the title
lloeki
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM code-wise.
That said, I did not do it on the original PR that tagged on service entry span because I thought it was specified that these tags should be on the closest span where the event happened, not the service entry span.
Therefore if it is so, and since this appears to be borne out of system tests failing, I'm questioning whether the system tests actually respect the RFC.
GustavoCaso
deleted the
appsec-make-sure-tags-are-added-to-service-entry-span
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
scope.service_entry_spanwhen tagging a span with appsec related tags.Motivation
Make sure AppSec features work as expected, and confront to the system tests specs
Additional Notes
How to test the change?
CI