Call Devise RegistrationsController block #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Devise user calls create with a block, that block was swallowed by the block we use to perform our resource information extraction for registration events. Ensure the original block is called. We call it after our analysis in the event we should block for some reason, thus protecting the additional user code in their block. JIRA: - [SCRS-704](https://datadoghq.atlassian.net/browse/SCRS-704) - [APPSEC-12115](https://datadoghq.atlassian.net/browse/APPSEC-12115) - [APPSEC-12770](https://datadoghq.atlassian.net/browse/APPSEC-12770)
github-actions
bot
added
appsec
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3286 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 1253 1253
Lines 72479 72545 +66
Branches 3403 3404 +1
=======================================
+ Hits 71194 71260 +66
Misses 1285 1285 ☔ View full report in Codecov by Sentry. |
anmarchenko
approved these changes
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a Devise user calls create with a block, that block was swallowed by the block we use to perform our resource information extraction for registration events.
Ensure the original block is called. We call it after our analysis in the event we should block for some reason, thus protecting the additional user code in their block.
Motivation:
User-reported issue.
Additional Notes:
JIRA:
How to test the change?
Specs
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!