Remove distributed_tracing option namespacing #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
rename-distributed-trace-options
branch
from
1554aef
to
533ebb6
Compare
brett0000FF
approved these changes
Dec 19, 2023
TonyCTHsu
approved these changes
Jan 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3338 +/- ##
==========================================
+ Coverage 98.11% 98.12% +0.01%
==========================================
Files 1250 1243 -7
Lines 72401 72014 -387
Branches 3391 3376 -15
==========================================
- Hits 71033 70662 -371
+ Misses 1368 1352 -16 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
Programmatic configuration options have been made more consistent with their respective environment variables:
tracing.distributed_tracing.propagation_extract_firsttracing.propagation_extract_firstDD_TRACE_PROPAGATION_EXTRACT_FIRSTtracing.distributed_tracing.propagation_extract_styletracing.propagation_style_extractDD_TRACE_PROPAGATION_STYLE_EXTRACTtracing.distributed_tracing.propagation_inject_styletracing.propagation_style_injectDD_TRACE_PROPAGATION_STYLE_INJECTtracing.distributed_tracing.propagation_styletracing.propagation_styleDD_TRACE_PROPAGATION_STYLEMotivation:
Environment variable naming is standard across all Datadog languages.
Our programmatic configuration API is an extra avenue for configuration for Ruby clients, and reflects the same options as the ones provided by environment variables.
The naming between the programmatic variant and the environment variable variant of the same option should be as close as possible.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!