Remove distributed_tracing option namespacing #3338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
Programmatic configuration options have been made more consistent with their respective environment variables:
tracing.distributed_tracing.propagation_extract_first
tracing.propagation_extract_first
DD_TRACE_PROPAGATION_EXTRACT_FIRST
tracing.distributed_tracing.propagation_extract_style
tracing.propagation_style_extract
DD_TRACE_PROPAGATION_STYLE_EXTRACT
tracing.distributed_tracing.propagation_inject_style
tracing.propagation_style_inject
DD_TRACE_PROPAGATION_STYLE_INJECT
tracing.distributed_tracing.propagation_style
tracing.propagation_style
DD_TRACE_PROPAGATION_STYLE
Motivation:
Environment variable naming is standard across all Datadog languages.
Our programmatic configuration API is an extra avenue for configuration for Ruby clients, and reflects the same options as the ones provided by environment variables.
The naming between the programmatic variant and the environment variable variant of the same option should be as close as possible.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!