[PROF-8944] Upgrade to libdatadog 6 #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Feb 12, 2024
**What does this PR do?** This PR bumps the libdatadog version to 6.0.0 in preparation for release. We're going from 5.0.0 to 6.0.0 because of a small, yet still backwards-incompatible change in the profiling APIs (see below). **Motivation:** Release libdatadog 6.0.0. **Additional Notes:** As far as I could spot, the only backwards incompatible API change is: * `ProfileExporter::build`/`ddog_prof_Exporter_Request_build` now take an extra (optional/can be `NULL`) argument for attaching system information [#289](#289) **How to test the change?** I've tested the libdatadog 6 release locally using the Ruby profiler, see DataDog/dd-trace-rb#3455 for my draft PR.
Merged
2 tasks
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Feb 12, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also exactly the same as the [v5.0.0 release PR](#267)). **Motivation:** Enable Ruby to use libdatadog v6.0.0. **Additional Notes:** N/A **How to test the change?** I've tested this release locally against the changes in DataDog/dd-trace-rb#3455 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
2 tasks
**What does this PR do?** This PR upgrades dd-trace-rb to use libdatadog 6. The highlight of this release are memory footprint improvements when using the profiling timeline feature. There was a small breaking API change -- the addition of the `info` parameter in `ddog_prof_Exporter_Request_build`, which will be used in #3357 but for this PR I only passed in a `NULL`. **Motivation:** Pick up the timeline memory improvements. **Additional Notes:** N/A **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
ivoanjo
force-pushed
the
ivoanjo/prof-8944-libdatadog6-upgrade
branch
from
1a9c462
to
3cd8494
Compare
AlexJF
approved these changes
Feb 12, 2024
|
The GitHub macOS test runners seem to be MIA. Since libdatadog upgrades are not known for affecting macOS, I'm going to go ahead and press the merge button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades dd-trace-rb to use libdatadog 6. The highlight of this release are memory footprint improvements when using the profiling timeline feature.
There was a small breaking API change -- the addition of the
infoparameter inddog_prof_Exporter_Request_build, which will be used in #3357 but for this PR I only passed in aNULL.Motivation:
Pick up the timeline memory improvements.
Additional Notes:
I'm opening this as a draft PR as libdatadog 6 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.Update: Ready!How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.