[PROF-8037] Profiling system info support #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
github-actions
bot
added
core
AlexJF
force-pushed
the
alexjf/system-info-collector
branch
from
d09cc4c
to
230da3c
Compare
AlexJF
commented
Jan 2, 2024
ivoanjo
reviewed
Jan 8, 2024
Profile sent with latest version of this PR |
2 tasks
ivoanjo
added a commit
that referenced
this pull request
Feb 12, 2024
**What does this PR do?** This PR upgrades dd-trace-rb to use libdatadog 6. The highlight of this release are memory footprint improvements when using the profiling timeline feature. There was a small breaking API change -- the addition of the `info` parameter in `ddog_prof_Exporter_Request_build`, which will be used in #3357 but for this PR I only passed in a `NULL`. **Motivation:** Pick up the timeline memory improvements. **Additional Notes:** N/A **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
2 tasks
ivoanjo
added a commit
that referenced
this pull request
Feb 12, 2024
**What does this PR do?** This PR upgrades dd-trace-rb to use libdatadog 6. The highlight of this release are memory footprint improvements when using the profiling timeline feature. There was a small breaking API change -- the addition of the `info` parameter in `ddog_prof_Exporter_Request_build`, which will be used in #3357 but for this PR I only passed in a `NULL`. **Motivation:** Pick up the timeline memory improvements. **Additional Notes:** N/A **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3357 +/- ##
========================================
Coverage 98.23% 98.23%
========================================
Files 1270 1272 +2
Lines 74802 74970 +168
Branches 3510 3531 +21
========================================
+ Hits 73479 73647 +168
Misses 1323 1323 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
ivoanjo
added a commit
that referenced
this pull request
Feb 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
info.application.start_time:Motivation:
Additional Notes:
This requires using a new release of libdatadog with DataDog/libdatadog#289 merged
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!