AWS span.resource does not give a meaningful insight on service page

[jfrancoist]

When using the current :aws instrumentation. We get the following resource

I think it would make more sense to have the name of the AWS command listed here instead. Which would result finding out which command is performing poorly instead of having to go through each trace on the next screen?

This line: https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/contrib/aws/instrumentation.rb#L31 could change to

span.resource = context.safely(:resource)

making the service page show a list of AWS command in the format [aws_service].[method] e.g s3.head_object

And maybe https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/contrib/aws/instrumentation.rb#L30 to

span.name = RESOURCE

[delner]

From a quick 2 minute look, this seems reasonable and could address your issue. Will take a deeper look at this later. Thanks for bringing it up!

[jfrancoist]

Hi David, I took the opportunity to create a small PR and with some screenshots of the resulting behaviour. JF

…

On 20 March 2018 at 16:16, David Elner ***@***.***> wrote: From a quick 2 minute look, this seems reasonable and could address your issue. May I suggest opening a pull request and showing the effect it has through a couple more screenshots? Would probably be the best means of having this expedited! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#374 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGSe2jQzbihVPv1Ap8gb03efpghDWCUVks5tgR07gaJpZM4SxfbX> .

[delner]

Awesome, thanks a lot. I'll take a look!

[delner]

This should be fixed in #377 and will roll with 0.12.1, closing this issue.