Require rspec-core for RSpec integration
#1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for projects that use `rspec-rails` instead of standard `rspec`. (Both explicitly depend on `rspec-core`.)
elliterate
force-pushed
the
rspec-integration-require-rspec-core
branch
from
c05236a
to
06c41f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 913 913
Lines 44247 44247
=======================================
Hits 43501 43501
Misses 746 746
Continue to review full report at Codecov.
|
marcotc
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Thank you so much, @elliterate!
This is a very nice catch. Your PR is more precise than our previous implementation.
🙇
marcotc
added
ci-app
|
@elliterate, thank you again for your contribution. 0.53.0 was just released, including the changes in this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for projects that use
rspec-railsinstead of standardrspec. (Both explicitly depend onrspec-core.)