-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GraphQL 2.0 #1982
Changes from all commits
e329c8c
b65b4be
370e090
c414774
6af8158
56a2e06
03aee1b
0ce85b9
0146358
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -276,7 +276,7 @@ elsif ruby_version?('2.2') | |
gem 'excon' | ||
gem 'faraday' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql' | ||
gem 'grpc', '~> 1.19.0' # Last version to support Ruby < 2.3 & google-protobuf < 3.7 | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -459,7 +459,7 @@ elsif ruby_version?('2.3') | |
gem 'excon' | ||
gem 'faraday' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql' | ||
gem 'grpc' | ||
gem 'google-protobuf', '~> 3.11.0' # Last version to support Ruby < 2.5 | ||
gem 'hiredis' | ||
|
@@ -577,7 +577,7 @@ elsif ruby_version?('2.4') | |
gem 'excon' | ||
gem 'faraday' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc' | ||
gem 'google-protobuf', '~> 3.11.0' # Last version to support Ruby < 2.5 | ||
gem 'hiredis' | ||
|
@@ -613,6 +613,7 @@ elsif ruby_version?('2.4') | |
|
||
appraise 'contrib-old' do | ||
gem 'faraday', '0.17' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
|
||
appraise 'core-old' do | ||
|
@@ -821,7 +822,7 @@ elsif ruby_version?('2.5') | |
gem 'excon' | ||
gem 'faraday' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc', platform: :ruby | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -859,8 +860,9 @@ elsif ruby_version?('2.5') | |
end | ||
|
||
appraise 'contrib-old' do | ||
gem 'faraday', '0.17' | ||
gem 'dalli', '< 3.0.0' | ||
gem 'faraday', '0.17' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
|
||
appraise 'core-old' do | ||
|
@@ -1044,7 +1046,7 @@ elsif ruby_version?('2.6') | |
gem 'excon' | ||
gem 'faraday' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc', platform: :ruby | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -1081,8 +1083,9 @@ elsif ruby_version?('2.6') | |
end | ||
|
||
appraise 'contrib-old' do | ||
gem 'faraday', '0.17' | ||
gem 'dalli', '< 3.0.0' | ||
gem 'faraday', '0.17' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
|
||
appraise 'core-old' do | ||
|
@@ -1248,7 +1251,7 @@ elsif ruby_version?('2.7') | |
gem 'ethon' | ||
gem 'excon' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc' | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -1282,8 +1285,9 @@ elsif ruby_version?('2.7') | |
end | ||
|
||
appraise 'contrib-old' do | ||
gem 'faraday', '0.17' | ||
gem 'dalli', '< 3.0.0' | ||
gem 'faraday', '0.17' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
|
||
appraise 'core-old' do | ||
|
@@ -1361,7 +1365,7 @@ elsif ruby_version?('3.0') || ruby_version?('3.1') | |
gem 'ethon' | ||
gem 'excon' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc', '>= 1.38.0' # Minimum version with Ruby 3.0 support | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -1397,6 +1401,7 @@ elsif ruby_version?('3.0') || ruby_version?('3.1') | |
|
||
appraise 'contrib-old' do | ||
gem 'dalli', '< 3.0.0' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
|
||
appraise 'core-old' do | ||
|
@@ -1474,7 +1479,7 @@ elsif ruby_version?('3.2') | |
gem 'ethon' | ||
gem 'excon' | ||
gem 'grape' | ||
gem 'graphql', '>= 1.12.0', '< 1.13.0' # Newer versions are broken, needs to be investigated, see https://github.com/DataDog/dd-trace-rb/issues/1866 | ||
gem 'graphql', '>= 2.0' | ||
gem 'grpc', '>= 1.38.0' # Minimum version with Ruby 3.0 support | ||
gem 'hiredis' | ||
gem 'http' | ||
|
@@ -1510,6 +1515,7 @@ elsif ruby_version?('3.2') | |
|
||
appraise 'contrib-old' do | ||
gem 'dalli', '< 3.0.0' | ||
gem 'graphql', '>= 1.12.0', '< 2.0' | ||
end | ||
Comment on lines
1516
to
1519
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apologies for the annoyance -- could you also enable this for 3.2 which I've merged recently in #1974 ? Note: This also needs a fix on the Don't bother updating the gemfiles for 3.2 since we still haven't got it enabled in CI; we'll need to do it later anyway. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
|
||
appraise 'core-old' do | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify -- I'm assuming this PR also fixes #1866 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does! Thank you for the reminder.