-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-4780] Add libddprof dependency to power the new Ruby profiler #2028
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
eabedb8
Revert "Temporarily disable linking to libddprof"
ivoanjo 9db6ba4
Minor: Fix typo
ivoanjo 08c4759
Enable running profiler specs on macOS
ivoanjo ab89b4a
Upgrade libddprof to 0.4.0, switch to dynamic library, add arm64 support
ivoanjo 7f44784
Make libddprof a dependency of dd-trace-rb
ivoanjo 457af97
Cleanup: Make failure reason an argument to skip_building_extension!
ivoanjo 112d104
Refactor handling and printing of failures to install the profiling n…
ivoanjo 5de277d
Record failure to compile profiling extension and present info when t…
ivoanjo d5d1ed7
Drop profiler support for macOS
ivoanjo 374b85e
Improve spec descriptions
ivoanjo 945d939
Fix failing spec when running on macOS with testing override but a br…
ivoanjo 7b676b7
Upgrade to libddprof 0.5.0.1.0
ivoanjo d2fa19c
Upgrade to libddprof 0.6.0.1.0
ivoanjo 581e871
Fix broken spec on JRuby
ivoanjo 401eb0f
Explicitly ask for C99 when compiling, to avoid issues with older com…
ivoanjo a12069c
Tiny code cleanup to avoid JRuby bug
ivoanjo 6c46cba
Rubocop fixes
ivoanjo aab9ea7
Fix for broken test because `Profiling.supported?` tries to read a file
ivoanjo 47d8e66
Update ext/ddtrace_profiling_native_extension/extconf.rb
ivoanjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's real now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LET'S GO!!!