Replace libddprof dependency with libdatadog, and upgrade to 0.7.0
#2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
approved these changes
May 31, 2022
`libdatadog` is the new name of `libddprof`, and thus the gem name changed to match. This commit includes only the Ruby-level changes; C API changes from the 0.6.0 to 0.7.0 release will be fixed separately.
Now that we can explicitly get rid of the request, we can simplify the `pending_exception` code path when reporting a profile.
ivoanjo
force-pushed
the
ivoanjo/upgrade-to-libdatadog-0.7.0
branch
from
fcb20ff
to
142d404
Compare
|
Update: I've just rebased this PR on top of current ✅. I plan to keep it marked as draft until we put out dd-trace-rb 1.2.0 (no need to risk last-minute stability), but otherwise it's ready. |
|
dd-trace-rb 1.2.0 is now out, so I'm pressing the magic button! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libddprofdependency has been renamedlibdatadog.This PR updates dd-trace-rb to use the new version, including a few API changes from the 0.6 to 0.7 release.
I'm marking this PR as a draft because the only
libdatadogversion right now is0.7.0.1.0.rc1and I want to avoid releasing a rc1 to customers. Once the final 0.7.0 release hits, we just need to change thegemspecand merge.