W3C: Propagate unknown values as-is #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
w3c-propagate-unknown
branch
from
d7e0870
to
b7e6c91
Compare
ivoanjo
reviewed
Dec 13, 2022
TonyCTHsu
approved these changes
Dec 14, 2022
| end | ||
| end | ||
|
|
||
| [origin, sampling_priority, tags] | ||
| [origin, sampling_priority, tags, unknown_fields] |
There was a problem hiding this comment.
Perhaps we should extract this to its own object, if the array keeps on growing. It feels weird to me that the caller need to understand the index of the array to get the corresponding value.
There was a problem hiding this comment.
I'll do it if we get to 5! 🦆
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown Datadog-specific fields should be propagated as-is, as they might belong to future versions Datadog Tracers.
ddtrace's job is to simply pass the them downstream with the same incoming values.