Pin rake-compiler version as workaround for issue with Ruby <= 2.5 #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR pins the version of the `rake-compiler` dependency to fix an incompatibility between version 1.2.4 and Ruby <= 2.5. (Version 1.2.4 was just released on 2023-08-01) Those versions fail when running `bundle exec rake clean compile` to compile the profiling native extension with: ``` rake aborted! NoMethodError: undefined method `cleanpath' for #<String:0x00005eaf10da03e0> rake-compiler-1.2.4/lib/rake/extensiontask.rb:166:in `block in define_compile_tasks' ``` **Motivation**: Unbreak our CI. **Additional Notes**: I plan to also report this upstream. This will not affect customers, as `rake-compiler` is only used in development. **How to test the change?**: Validate that CI is back to green (or run `bundle exec rake clean compile` on Ruby <= 2.5 and validate it works).
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 1317 1317
Lines 74362 74362
Branches 3402 3402
=======================================
+ Hits 72943 72947 +4
+ Misses 1419 1415 -4 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Aug 2, 2023
|
This is no longer needed! After this was reported, the Closing :) |
GustavoCaso
deleted the
ivoanjo/workaround-rake-compiler-legacy-rubies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR pins the version of the
rake-compilerdependency to fix an incompatibility between version 1.2.4 and Ruby <= 2.5.(Version 1.2.4 was just released on 2023-08-01)
Those versions fail when running
bundle exec rake clean compileto compile the profiling native extension with:Motivation:
Unbreak our CI.
Additional Notes:
I plan to also report this upstream.
This will not affect customers, as
rake-compileris only used in development.How to test the change?:
Validate that CI is back to green (or run
bundle exec rake clean compileon Ruby <= 2.5 and validate it works).