Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename core configuration option on_set to after_set #3107

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

GustavoCaso
Copy link
Member

What does this PR do?

Rename the configuration on_set to after_set to better reflect the nature of it. It is a callback executed after the value has been set.

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@GustavoCaso GustavoCaso requested a review from a team September 4, 2023 15:44
@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Sep 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3107 (26ad90f) into master (f2c8241) will decrease coverage by 0.01%.
Report is 16 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
- Coverage   98.16%   98.15%   -0.01%     
==========================================
  Files        1323     1323              
  Lines       75155    75155              
  Branches     3428     3428              
==========================================
- Hits        73773    73771       -2     
- Misses       1382     1384       +2     
Files Changed Coverage Δ
lib/datadog/tracing/distributed/propagation.rb 92.10% <ø> (ø)
lib/datadog/core/configuration/option.rb 100.00% <100.00%> (ø)
...ib/datadog/core/configuration/option_definition.rb 98.85% <100.00%> (ø)
lib/datadog/core/configuration/settings.rb 98.47% <100.00%> (ø)
lib/datadog/tracing/configuration/settings.rb 94.92% <100.00%> (ø)
...cing/contrib/action_pack/configuration/settings.rb 96.29% <100.00%> (ø)
...og/tracing/contrib/rails/configuration/settings.rb 97.67% <100.00%> (ø)
...dog/tracing/contrib/rake/configuration/settings.rb 100.00% <100.00%> (ø)
...tadog/core/configuration/option_definition_spec.rb 100.00% <100.00%> (ø)
spec/datadog/core/configuration/option_spec.rb 99.62% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GustavoCaso GustavoCaso merged commit 744b96e into master Sep 5, 2023
205 checks passed
@GustavoCaso GustavoCaso deleted the core-configuration-rename-on_set-to-after_set branch September 5, 2023 07:58
@github-actions github-actions bot added this to the 1.15.0 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants