Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Ruby 2.1, 2.2, 2.3, 2.4 #3291

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Remove support for Ruby 2.1, 2.2, 2.3, 2.4 #3291

merged 6 commits into from
Nov 30, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 29, 2023

2.0 Upgrade Guide notes

The minimum version of Ruby supported by ddtrace 2.x is 2.5.0.
To install ddtrace for Ruby 2.1, 2.2, 2.3, or 2.4, you can use ddtrace 1.x.

Motivation:

Reduce CI runtime immediately.
There are no code changes, as they can cause conflicts until we get 2.0 released.
Those changes will come later in the release process.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc force-pushed the drop-old-rubies-ci branch 4 times, most recently from e0c0270 to 8ee3e92 Compare November 29, 2023 23:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d4dad6) 98.22% compared to head (1e59823) 97.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3291      +/-   ##
==========================================
- Coverage   98.22%   97.99%   -0.24%     
==========================================
  Files        1253     1248       -5     
  Lines       72545    72058     -487     
  Branches     3404     3401       -3     
==========================================
- Hits        71260    70615     -645     
- Misses       1285     1443     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc marked this pull request as ready for review November 30, 2023 18:41
@marcotc marcotc requested review from a team as code owners November 30, 2023 18:41
@marcotc marcotc self-assigned this Nov 30, 2023
docs/Compatibility.md Outdated Show resolved Hide resolved
@marcotc marcotc mentioned this pull request Nov 30, 2023
2 tasks
Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marcotc marcotc merged commit f13a1ce into 2.0 Nov 30, 2023
151 checks passed
@marcotc marcotc deleted the drop-old-rubies-ci branch November 30, 2023 21:29
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@marcotc marcotc mentioned this pull request Apr 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants