Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated profiler config options #3309

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Dec 6, 2023

2.0 Upgrade Guide notes
The following profiler configuration options have been removed: max_events, legacy_transport_enabled, force_enable_new_profiler and force_enable_legacy_profiler. Users should remove these from their configuration blocks. These options have not been functional since the GA release of CPU profiler 2.0.

What does this PR do?
Removes four configuration options for the profiler that have been deprecated and non-functional since GA of the 2.0 profiler.

Motivation:
Non-functional, deprecated options.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ekump ekump requested a review from a team as a code owner December 6, 2023 22:55
@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 6, 2023
@ekump ekump requested review from ivoanjo and a team and removed request for a team December 6, 2023 22:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfc5ab3) 97.99% compared to head (13986cb) 97.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3309   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files        1248     1248           
  Lines       72052    72024   -28     
  Branches     3394     3394           
=======================================
- Hits        70609    70583   -26     
+ Misses       1443     1441    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for going ahead and preparing this PR.

@ekump ekump merged commit e7bfaa7 into 2.0 Dec 7, 2023
152 checks passed
@ekump ekump deleted the ekump/remove-deprecated-profiler-config-options branch December 7, 2023 13:21
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@marcotc marcotc mentioned this pull request Apr 2, 2024
2 tasks
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants