remove deprecated profiler config options #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
requested review from
ivoanjo and
a team
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3309 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 1248 1248
Lines 72052 72024 -28
Branches 3394 3394
=======================================
- Hits 70609 70583 -26
+ Misses 1443 1441 -2 ☔ View full report in Codecov by Sentry. |
ivoanjo
approved these changes
Dec 7, 2023
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The following profiler configuration options have been removed:
max_events,legacy_transport_enabled,force_enable_new_profilerandforce_enable_legacy_profiler. Users should remove these from their configuration blocks. These options have not been functional since the GA release of CPU profiler 2.0.What does this PR do?
Removes four configuration options for the profiler that have been deprecated and non-functional since GA of the 2.0 profiler.
Motivation:
Non-functional, deprecated options.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!