Remove deprecated HTTP Transport methods #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
approved these changes
Dec 15, 2023
ivoanjo
reviewed
Dec 15, 2023
| 'be removed on a future ddtrace release.' | ||
| ) | ||
|
|
||
| DO_NOT_USE_ENVIRONMENT_AGENT_SETTINGS.hostname |
There was a problem hiding this comment.
Minor: I wonder if DO_NOT_USE_ENVIRONMENT_AGENT_SETTINGS still gets used in practice, or if it is a no-op default that always gets replaced by whatever we pass in.
There was a problem hiding this comment.
When I played around with dependency injection, I did find I believe 1 or 2 places that really still use it, and all the other references were non-functional (value is passed, but never used).
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
Removed unused, non-public methods:
Datadog::Tracing::Transport::HTTP#default_hostnameDatadog::Tracing::Transport::HTTP#default_portDatadog::Tracing::Transport::HTTP#default_urlDatadog::Core::Remote::Transport::HTTP#default_hostnameDatadog::Core::Remote::Transport::HTTP#default_portDatadog::Core::Remote::Transport::HTTP#default_urlMotivation:
These methods are unused and sit very oddly in the transport object themselves.
Additional Notes:
These methods were never public.
How to test the change?
All changes are covered by tests (meaning no change in behavior, since these methods are unused).
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!