Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive require in Railtie #3365

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix recursive require in Railtie #3365

merged 2 commits into from
Jan 5, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 4, 2024

Fixes #3340

What does this PR do?
This PR removes a redundant require on the DatadogAutoInstrumentRailtie class.
It's not possible to run this code today without the required file already being loaded.

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner January 4, 2024 22:44
@marcotc marcotc self-assigned this Jan 4, 2024
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 4, 2024
@marcotc marcotc requested a review from a team as a code owner January 5, 2024 20:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d809f33) 98.23% compared to head (307c740) 98.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3365   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files        1254     1254           
  Lines       73217    73217           
  Branches     3430     3430           
=======================================
+ Hits        71928    71931    +3     
+ Misses       1289     1286    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 4eac863 into master Jan 5, 2024
218 checks passed
@marcotc marcotc deleted the fix-recursive branch January 5, 2024 20:42
@github-actions github-actions bot added this to the 1.19.0 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular require warning
4 participants