Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request #3367

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 5, 2024

2.0 Upgrade Guide notes

The undocumented HTTP hook Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request has been removed. This hook was intrusive, only restricted to the net/http client, and was not generalizable to other HTTP client gems.

If you require this hook, please open a "Feature request" stating your use case so we can asses how to best support it.

Additional Notes:

We are open to adding similar capabilities in the future, but we should asses the concrete user needs for such hook.

How to test the change?

All changes are covered by unit testing. In this case, the tests are removed due to the removal of the feature.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner January 5, 2024 20:28
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 5, 2024
@marcotc marcotc changed the title Remove Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request Remove Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be1c557) 98.11% compared to head (9c3d405) 98.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3367   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files        1248     1248           
  Lines       72285    72257   -28     
  Branches     3391     3384    -7     
=======================================
- Hits        70920    70894   -26     
+ Misses       1365     1363    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants