Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binding.pry comment #3456

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove binding.pry comment #3456

merged 1 commit into from
Feb 12, 2024

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Feb 12, 2024

Removes comment of binding.pry that was mistakenly merged in #3345

@zarirhamza zarirhamza requested a review from a team as a code owner February 12, 2024 15:31
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 12, 2024
@zarirhamza zarirhamza mentioned this pull request Feb 12, 2024
2 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (fe8c8a3) 98.26% compared to head (f7eb872) 98.23%.
Report is 48 commits behind head on master.

Files Patch % Lines
spec/datadog/tracing/contrib/http_route_spec.rb 85.86% 26 Missing ⚠️
spec/datadog/tracing/contrib/extensions_spec.rb 92.30% 3 Missing ⚠️
spec/datadog/profiling/stack_recorder_spec.rb 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3456      +/-   ##
==========================================
- Coverage   98.26%   98.23%   -0.04%     
==========================================
  Files        1269     1270       +1     
  Lines       74477    74802     +325     
  Branches     3485     3510      +25     
==========================================
+ Hits        73185    73481     +296     
- Misses       1292     1321      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 binding.lgtm

@marcotc marcotc merged commit 65f12dd into master Feb 12, 2024
131 of 146 checks passed
@marcotc marcotc deleted the zarir/remove-binding-pry branch February 12, 2024 16:11
@github-actions github-actions bot added this to the 1.21.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants