[PROF-9163] Fix missing profiling code hotspots when using ddtrace+otel #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble @profiler_info not initialized"
**What does this PR do?** This PR fixes the profiler not sending code hotspots data when ddtrace is being used with OpenTelemetry (e.g. [when following these instructions](https://docs.datadoghq.com/tracing/trace_collection/custom_instrumentation/otel_instrumentation/ruby/)). Note that in particular this only works in apps that use ```ruby require 'datadog/opentelemetry' ``` **Motivation:** Since in this mode, otel data goes through ddtrace, code hotspots should be correctly supported. The only reason this didn't work is that otel spans were handled slightly differently, and the profiler was not correctly accounting for this. **Additional Notes:** N/A **How to test the change?** I've updated the `Rakefile` to run the profiler test suite with and without opentelemetry, and added test coverage for this. To test it manually, you can add `gem 'opentelemetry-sdk'` to your Gemfile, and the specs will run. Here's also a trivial app you can use for testing: ```ruby require 'opentelemetry/sdk' require 'datadog/opentelemetry' OpenTelemetry::SDK.configure MyAppTracer = OpenTelemetry.tracer_provider.tracer('otel-testing') MyAppTracer.in_span("do_work") do |span| sleep 2 end ```
AlexJF
approved these changes
Feb 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the profiler not sending code hotspots data when ddtrace is being used with OpenTelemetry (e.g. when following these instructions).
Note that in particular this only works in apps that use
Motivation:
Since in this mode, otel data goes through ddtrace, code hotspots should be correctly supported. The only reason this didn't work is that otel spans were handled slightly differently, and the profiler was not correctly accounting for this.
Additional Notes:
N/A
How to test the change?
I've updated the
Rakefileto run the profiler test suite with and without opentelemetry, and added test coverage for this.To test it manually, you can add
gem 'opentelemetry-sdk'to your Gemfile, and the specs will run.Here's also a trivial app you can use for testing: