Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bin/ddtracerb #3506

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove bin/ddtracerb #3506

merged 1 commit into from
Mar 11, 2024

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 5, 2024

2.0 Upgrade Guide notes

bin/ddtracerb has been removed. Use bin/ddprofrb instead.

What does this PR do?

Removes the deprecated bin/ddtracerb in favor of the new bin/ddprofrb.

Motivation:

The old binstub reflects a misleading name. It was deprecated in 1.x and removing this finalizes the rename.

@delner delner requested review from a team as code owners March 5, 2024 18:58
@delner delner changed the base branch from master to 2.0 March 5, 2024 18:58
@delner delner self-assigned this Mar 5, 2024
@delner delner added breaking-change Involves a breaking change feature Involves a product feature profiling Involves Datadog profiling 2.0 labels Mar 5, 2024
@delner delner added this to the 2.0 milestone Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (e414921) to head (e9985bf).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3506   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files        1237     1237           
  Lines       72254    72254           
  Branches     3408     3408           
=======================================
  Hits        70864    70864           
  Misses       1390     1390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ivoanjo ivoanjo mentioned this pull request Mar 7, 2024
@delner delner merged commit 344441e into 2.0 Mar 11, 2024
163 checks passed
@delner delner deleted the refactor/remove_bin_ddtracerb branch March 11, 2024 15:59
@ivoanjo ivoanjo modified the milestones: 2.0, 1.21.0 Mar 14, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 breaking-change Involves a breaking change feature Involves a product feature profiling Involves Datadog profiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants