Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add span links to the Datadog API #3546

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Mar 20, 2024

What does this PR do?

Introduces an API for generating and serializing span links using the Datadog API. Support for OTEL span links will be introduced in a future PR.

Inspiration: https://github.com/open-telemetry/opentelemetry-ruby/blob/b1d6d050c613ad81f51dbe6db498815deeb110d4/api/lib/opentelemetry/trace/link.rb#L13

Motivation:

Span Links provides a new mechanism to correlate spans.

Additional Notes:

  • This change requires datadog-agent v7.41. datadog-agent<7.41 does not support deserializing span links.
  • This is not a breaking change to the v0.4 trace API. Older versions of the agent will ignore the span_link field in trace payloads.

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@mabdinur mabdinur changed the title feat: Add span links to Datadog API feat: Add span links to the Datadog API Mar 20, 2024
@mabdinur mabdinur added this to the 2.0 milestone Mar 20, 2024
@mabdinur mabdinur force-pushed the munir/add-dd-span-links branch 2 times, most recently from e1346ba to 78e19ba Compare March 21, 2024 20:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (22f8d40) to head (c6431dd).
Report is 3 commits behind head on 2.0.

Additional details and impacted files
@@           Coverage Diff            @@
##              2.0    #3546    +/-   ##
========================================
  Coverage   98.11%   98.11%            
========================================
  Files        1236     1238     +2     
  Lines       72179    72303   +124     
  Branches     3396     3408    +12     
========================================
+ Hits        70815    70940   +125     
+ Misses       1364     1363     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mabdinur mabdinur marked this pull request as ready for review March 21, 2024 22:34
@mabdinur mabdinur requested a review from a team as a code owner March 21, 2024 22:34
@mabdinur mabdinur requested review from TonyCTHsu and marcotc and removed request for TonyCTHsu March 25, 2024 15:22
@marcotc marcotc self-requested a review March 28, 2024 21:32
@marcotc marcotc merged commit 584ce50 into 2.0 Apr 2, 2024
153 checks passed
@marcotc marcotc deleted the munir/add-dd-span-links branch April 2, 2024 19:45
@ivoanjo ivoanjo added the 2.0 label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants