Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use Bundler 1.17.3 #763

Merged
merged 3 commits into from
May 24, 2019
Merged

Conversation

delner
Copy link
Contributor

@delner delner commented May 23, 2019

Bundler is incorrectly resolving the correct versions of gems to be compatible with the version of Ruby it is trying to install them for. This results in failed builds, claiming a gem version requires a particular version of Ruby, even though an older version of the same gem would support the current version of Ruby.

This became an issue with #762 when it started resolving gem dependencies incorrectly.

For this PR to work, we will need to update the Docker images on Docker Hub accordingly. (Blocked on that change.)

@delner delner added bug Involves a bug dev/tooling Involves tools (e.g. Rubocop, CodeCov) dev/testing Involves testing processes (e.g. RSpec) labels May 23, 2019
@delner delner requested a review from brettlangdon May 23, 2019 20:36
@delner delner self-assigned this May 23, 2019
@delner delner merged commit 2e0a3b2 into master May 24, 2019
@delner delner deleted the ci/update_ci_bundler_to_1.17.3 branch May 24, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug dev/testing Involves testing processes (e.g. RSpec) dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants