Migrate image base to alpine #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
force-pushed
the
haissam/alpine-opt
branch
2 times, most recently
from
c1fc3ff
to
b1f8107
Compare
hkaj
force-pushed
the
haissam/alpine-opt
branch
from
b1f8107
to
f4eb6c3
Compare
Conflicts: Dockerfile entrypoint.sh
| @@ -1,46 +1,55 @@ | |||
| FROM debian:jessie | |||
| FROM alpine:3.3 | |||
| COPY conf.d/docker_daemon.yaml "$DD_HOME/agent/conf.d/docker_daemon.yaml" | ||
|
|
||
| # Add install and config files | ||
| ADD https://raw.githubusercontent.com/DataDog/dd-agent/5.8.0/packaging/datadog-agent/source/setup_agent.sh /setup_agent.sh |
There was a problem hiding this comment.
the agent version is hardcoded in the url. switch to env var:
ADD https://raw.githubusercontent.com/DataDog/dd-agent/$AGENT_VERSION/packaging/datadog-agent/source/setup_agent.sh /setup_agent.sh
|
|
|
thanks for the review @oryband :) let's do it |
|
Awesome! |
|
Btw, the image size was reduced from ~150MB to ~50MB which is 60% less, not 10%! Very nice! https://hub.docker.com/r/datadog/docker-dd-agent/tags/ Related to #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Basing the Datadog Agent image on Alpine0 would reduce its size and harden its security by default.
This PR adds an alpine directory to offer an alpine-based image on top of the debian-based one.
How it works
Starting from the
alpine:3.4base image, the image installs agent dependencies using Alpine's package managerapk.It then installs the agent from the source using https://github.com/DataDog/dd-agent/blob/5.8.0/packaging/datadog-agent/source/setup_agent.sh