Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dashboard read_only option #135

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Add dashboard read_only option #135

merged 2 commits into from
Jan 16, 2020

Conversation

tjoyal
Copy link
Contributor

@tjoyal tjoyal commented Aug 31, 2017

Followed the existing patterns.

We could:

  • Convert method parameters as named options
  • Format the body as 1.9 vs hash-rocket syntax

If we desire so, I can update.
Otherwise, this just work for me and is backward compatible.

Thoughts?

@github-actions
Copy link

github-actions bot commented Jan 4, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jan 4, 2020
@github-actions github-actions bot closed this Jan 11, 2020
@gzussa gzussa removed the stale Stale - Bot reminder label Jan 16, 2020
@gzussa gzussa reopened this Jan 16, 2020
@gzussa gzussa requested a review from a team January 16, 2020 15:47
@gzussa gzussa added changelog/Added Added features results into a minor version bump kind/feature-request Feature request related issue labels Jan 16, 2020
@gzussa gzussa requested a review from iddl January 16, 2020 15:50
@gzussa
Copy link
Contributor

gzussa commented Jan 16, 2020

@iddl Does this look good to you?

gzussa
gzussa approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. CI passes and it is indeed backward compatible.

@gzussa gzussa merged commit c4c87f5 into DataDog:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

@iddl iddl Awaiting requested review from iddl

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump kind/feature-request Feature request related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjoyal @gzussa