Use headers-only for api and app keys with exceptions #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to shubho/use-headers
gzussa
suggested changes
Oct 15, 2019
| params = extra_params.merge params unless extra_params.nil? | ||
| qs_params = params.map { |k, v| CGI.escape(k.to_s) + '=' + CGI.escape(v.to_s) } | ||
| qs = '?' + qs_params.join('&') | ||
| qs | ||
| end | ||
|
|
||
| def set_api_and_app_keys_in_params(url, with_app_key) |
There was a problem hiding this comment.
Thanks a lot for this 👏
Would it be possible to add a unit test forset_api_and_app_keys_in_params?
Good point. Added a unit test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog now supports api and app keys in headers. Refactoring ruby lib to use headers only. There is an exception for some endpoints which cannot support these