Bcon/make query optional monitor update #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcburney
reviewed
Oct 11, 2019
| body = { | ||
| 'query' => query, | ||
| }.merge options | ||
| body = {}.merge options |
There was a problem hiding this comment.
Rather than merging an empty hash, I would write it as :
def update_monitor(monitor_id, query, options)
unless query.nil?
options['query'] = query
warn '[DEPRECATION] query param is no longer required for update'
end
request(Net::HTTP::Put, "/api/#{API_VERSION}/monitor/#{monitor_id}", nil, options, true)
endThere was a problem hiding this comment.
For some reason it's being picky about the order and local tests don't pass with this
¯_(ツ)_/¯
|
One thing I forgot is you'll need to bump the version here. Just bumping it up to |
zippolyte
requested changes
Oct 14, 2019
lib/dogapi/v1/monitor.rb
Outdated
| body = { | ||
| 'query' => query | ||
| }.merge body | ||
| warn '[DEPRECATION] query param is no longer required for update' |
There was a problem hiding this comment.
I would not warn here. If someone does want to actually update the query, they should not see a deprecation message.
There was a problem hiding this comment.
Actually you were right to have this message. I misunderstood how all of it worked.
There was a problem hiding this comment.
Ok just put it back in with the updates!
zippolyte
approved these changes
Oct 17, 2019
zippolyte
requested changes
Oct 17, 2019
zippolyte
approved these changes
Oct 18, 2019
|
@zippolyte Great thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to DataDog/datadogpy#447
Made query an optional param. Tests pass locally, but happy to add some new testing if appropriate.