Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby cloud integration support #201

Merged
merged 16 commits into from
Nov 21, 2019

Conversation

Ricky-Thomas
Copy link
Contributor

@Ricky-Thomas Ricky-Thomas commented Nov 11, 2019

Adding support for the following endpoints:

AWS

  • GET (list)
  • GET (list available namespaces)
  • POST (create account config)
  • DELETE (delete account config)
  • PUT (generate external ID)
  • PUT (update account)

AWS LOGS

  • GET (list AWS logs integrations)
  • POST (add aws log lambda ARN)
  • DELETE (delete lambda ARN config)
  • POST (aws integration logs check lambda async) - check if lambda_arn exists within account
  • GET (list log services)
  • POST (AWS Integration Logs check Services Async)
  • POST (save services - this is what needs to run after the previous one to save the services they want for the recently added ARN)

AZURE ENDPOINTS

  • GET (list all azure integrations)
  • POST (create an azure integration)
  • DELETE (delete an azure integration)
  • POST (update host filters)
  • PUT (update account)

GCP ENDPOINTS

  • GET list
  • POST create
  • DELETE delete
  • PUT (set GCP integration automute.) This also updates host filters. And is truly the only use case for updating a config here. It will allow you to update other fields as well, but not project_id and client_email which are the required fields. If those fields are to be updated an entirely new config should be created. We need to update the docs to reflect this info.

ORIGINAL PR was here: #190
I messed up the history of that one with a rebase, but fixed in this branch. Unfortunately the comments from @mattsp1290 and @zippolyte couldn't be transferred over but their comments were addressed here.

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.
Some (maybe) naive questions here and there. Let's clean names as well so we are consistent within this SDK but also cross SDK. We should always have integration when mentioning providers.
regarding your testing scenarios. I trust you so thay are as complete as possible 😄

lib/dogapi/facade.rb Outdated Show resolved Hide resolved
lib/dogapi/v1.rb Show resolved Hide resolved
lib/dogapi/v1/aws_integration.rb Outdated Show resolved Hide resolved
lib/dogapi/v1/gcp_integration.rb Outdated Show resolved Hide resolved
lib/dogapi/v1/azure_integration.rb Outdated Show resolved Hide resolved
lib/dogapi/v1/aws_logs.rb Outdated Show resolved Hide resolved
@Ricky-Thomas
Copy link
Contributor Author

@gzussa Thanks for the feedback here. I've updated the PR and this is ready for another look. Thanks!

@gzussa gzussa requested a review from a team November 19, 2019 17:08
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@zippolyte zippolyte merged commit b65a476 into master Nov 21, 2019
@zippolyte zippolyte deleted the ricky-add_ruby_cloud_integration_support branch November 21, 2019 09:46
nmuesch added a commit that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants