Fix cancel_downtime_by_scope method by setting send_json to true.
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
approved these changes
Dec 9, 2019
nmuesch
reviewed
Dec 13, 2019
| @@ -1,3 +1,3 @@ | |||
| module Dogapi | |||
| VERSION = '1.37.1' | |||
| VERSION = '1.37.2' | |||
There was a problem hiding this comment.
No need to change this while creating features, it'll get bumped at release time 😄 (No need to change it back, just wanted to give a heads up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't send the
{ 'scope' => scope }JSON options, because we had theset_jsonparameter for therequestfunction set tofalse. This PR fixes thecancel_downtime_by_scopemethod to send the JSON in the request.Current functionality: