Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synthetics support #210

Merged
merged 36 commits into from
Jan 24, 2020
Merged

Add Synthetics support #210

merged 36 commits into from
Jan 24, 2020

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Jan 10, 2020

What does this PR do?

Adds support for Synthetics, follow up from #175 if we do not hear back from the contributor.

Description of the Change

No support existed for Synthetics within this client.

Alternate Designs

N/A

Possible Drawbacks

N/A - does not touch other features within this client.

Verification Process

  • Integration tests
    Manually test the endpoints
  • GET devices
  • GET locations
  • GET all tests
  • GET info about a test
  • GET most recent results about a test
  • POST PUT start or pause test.
  • GET a specific result
  • POST create test
  • PUT edit test
  • POST delete tests

Release Notes

Add Synthetics support

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@dabcoder dabcoder marked this pull request as ready for review January 13, 2020 14:19
@dabcoder dabcoder requested a review from a team as a code owner January 13, 2020 14:19
@dabcoder dabcoder changed the title Add Synthetics support [WIP] Add Synthetics support Jan 14, 2020
@dabcoder dabcoder changed the title [WIP] Add Synthetics support Add Synthetics support Jan 15, 2020
@gzussa gzussa added changelog/Added Added features results into a minor version bump kind/feature-request Feature request related issue labels Jan 16, 2020
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Let's double check tests are valid.
Also could we have integration tests as well.

lib/dogapi/facade.rb Outdated Show resolved Hide resolved
lib/dogapi/facade.rb Outdated Show resolved Hide resolved
lib/dogapi/v1/synthetics.rb Outdated Show resolved Hide resolved
lib/dogapi/v1/synthetics.rb Outdated Show resolved Hide resolved
@gzussa gzussa requested review from zippolyte and a team January 16, 2020 14:38
lib/dogapi/facade.rb Outdated Show resolved Hide resolved
@dabcoder dabcoder merged commit 005a2b1 into master Jan 24, 2020
@dabcoder dabcoder deleted the davidb/synthetics branch January 24, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump kind/feature-request Feature request related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants