Improve user-agent header to include telemetry information #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
added
the
changelog/Added
jirikuncar
reviewed
Jul 2, 2020
lib/dogapi/common.rb
Outdated
Comment on lines
145
to
150
| req['User-Agent'] = 'dogapi-rb/%{version} (ruby %{ruver}; os %{os}; arch %{arch})' % { | ||
| :version => VERSION, | ||
| :ruver => RUBY_VERSION, | ||
| :os => RbConfig::CONFIG['host_os'].downcase, | ||
| :arch => RbConfig::CONFIG['host_cpu'] | ||
| } |
There was a problem hiding this comment.
We should probably send this always.
There was a problem hiding this comment.
What do you mean? We're adding it to each request right now, so that's always unless I'm missing something.
There was a problem hiding this comment.
Oh, I see what you mean, will fix.
jirikuncar
reviewed
Jul 2, 2020
lib/dogapi/common.rb
Outdated
Comment on lines
145
to
151
| req['User-Agent'] = 'dogapi-rb/%{version} (ruby %{ruver}; os %{os}; arch %{arch})' % { | ||
| :version => VERSION, | ||
| :ruver => RUBY_VERSION, | ||
| :os => RbConfig::CONFIG['host_os'].downcase, | ||
| :arch => RbConfig::CONFIG['host_cpu'] | ||
| } | ||
| end |
There was a problem hiding this comment.
Suggested change
| req['User-Agent'] = 'dogapi-rb/%{version} (ruby %{ruver}; os %{os}; arch %{arch})' % { | |
| :version => VERSION, | |
| :ruver => RUBY_VERSION, | |
| :os => RbConfig::CONFIG['host_os'].downcase, | |
| :arch => RbConfig::CONFIG['host_cpu'] | |
| } | |
| end | |
| end | |
| req['User-Agent'] = 'dogapi-rb/%{version} (ruby %{ruver}; os %{os}; arch %{arch})' % { | |
| :version => VERSION, | |
| :ruver => RUBY_VERSION, | |
| :os => RbConfig::CONFIG['host_os'].downcase, | |
| :arch => RbConfig::CONFIG['host_cpu'] | |
| } |
There was a problem hiding this comment.
It feels like the User-Agent value could be a constant.
There was a problem hiding this comment.
True, I can make it a constant.
|
@jirikuncar all done, please re-review. |
jirikuncar
approved these changes
Jul 2, 2020
|
Thanks for the review! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the user-agent header more useful.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.