Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular dependency #253

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Remove circular dependency #253

merged 2 commits into from
Jan 25, 2021

Conversation

zippolyte
Copy link
Contributor

What does this PR do?

Remove circular dependency. Closes #251

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@zippolyte zippolyte added the changelog/Fixed Fixed features results into a bug fix version bump label Jan 25, 2021
@zippolyte zippolyte requested a review from a team as a code owner January 25, 2021 12:39
@zippolyte
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte merged commit e2ef285 into master Jan 25, 2021
@zippolyte zippolyte deleted the hippo/circdep branch January 25, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circular loading warnings
2 participants
@zippolyte @jirikuncar