Optional automatic truncation of events that exceed the message length limit #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @daniel-chambers . We'll review this soon. |
|
Looks good! Thanks @daniel-chambers, merging this one. Thanks for keeping backwards compatibility! |
truthbk
added a commit
that referenced
this pull request
Oct 23, 2015
Optional automatic truncation of events that exceed the message length limit
|
This is great. Thanks @daniel-chambers! |
|
My pleasure. Thanks for merging it! |
|
Is it possible to get this out in a new NuGet package version? |
|
@daniel-chambers we will definitely do that soon! :) Apologies for the slow response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like metrics not to crash the application if the message happens to stray too long, preferring quiet truncation rather than exception throwing.
I've made the default behaviour retain the exception throwing, for backwards compat, but you can opt into truncation with an optional argument.
This should fix #16 too.