add TruncateIfTooLong to StatsdConfig
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/truncate-by-default
branch
from
2948184
to
3824008
Compare
Add `TruncateIfTooLong` parameter to `StatsdConfig`. When enabled (default to `True`), `StatsD` truncates any event and service checks when their size exceeds 8kB.
yannmh
force-pushed
the
yann/truncate-by-default
branch
from
3824008
to
595aead
Compare
truthbk
reviewed
Nov 16, 2017
There was a problem hiding this comment.
I don't see anything wrong with this. And pretty awesome that you added a test 🍰
My only question is if we need to add the truncate option to the calls, or if we should consider the StatsdConfig option as good enough. I don't have a strong preference, just wondering if it may be a bit of overkill.
jackellenberger
pushed a commit
to jackellenberger/dogstatsd-ruby
that referenced
this pull request
Dec 8, 2019
# What Instead of raising a RuntimeError and dropping the event when its formatted string version is greater than 8kb, make an effort to truncate the message portion of the event down to a sendable size. Add the option to disable this feature by passing in :truncate => false to @statsd.event. # Why It's not acceptable to have a silent failure around a seemingly arbitrary message length limitation, especially with Datadog's event monitors being so feature poor. This would be less of a problem if you could compose a monitor to query "has there been an error in the last 5 minutes, or has there not been a success in the last hour", but as it currently stands silent failures are a big weakness for our Datadog integration. The C# client library [accepted](DataDog/dogstatsd-csharp-client#55) a similar change, so it should fly in the ruby CL as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TruncateIfTooLongparameter toStatsdConfig. When enabled(default to
True),StatsDtruncates any event and service checkswhen their size exceeds 8kB.
Fix #48. Help #25.