-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Upload images to ECR #179
Conversation
- Configure AWS and log into ECR - Push the images to ECR
- Discount is now pointing to the correct repo - Storefront fixed is now using the correct branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I added some comments and questions.
- I was pointing to wrong ECR repo - Update workflow
Thank you @arapulido for your review. By the way, I should also update the doc to let people know about ECR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an image name that has changed its name
what do you mean by this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tdimnet , what AWS account owns these ECR repositories?
Hey @stanleegoodspeed! I send you the name of the account via Slack. And then, I'll merge this PR, it's been open for so long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I confirmed that the github workflows can push to the new ECR registries under the
dd-marketing
account in addition to the existing repos in Dockerhub (tested against thenginx
workflow + repos) - I confirmed that the images can be pulled as expected from ECR using the following docker compose service definition running locally:
nginx:
restart: always
image: public.ecr.aws/x2b9z2t7/ddtraining/nginx:latest
ports:
- "80:80"
depends_on:
- frontend
labels:
com.datadoghq.ad.logs: '[{"source": "nginx", "service": "nginx"}]'
Remaining Question
traffic-replay
is not included in the currentrelease
workflow and therefore has not been included in the new workflow. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I comment on some (but not all!) places where the dockerhub pushes were occuring. Let's ensure we're only pushing the the ECR registry with our automated builds.
Hi,
this is related to a discussion I had with Kirk. AWS wanted to use our Docker Images but they prefer using them on ECR instead of DockerHub.
I updated all of the Github actions in order to make them push the images to both DockerHub and ECR.
I also updated the release script and created the ECR Repo.