(feat) Upload images to ECR

[tdimnet]

Hi,

this is related to a discussion I had with Kirk. AWS wanted to use our Docker Images but they prefer using them on ECR instead of DockerHub.

I updated all of the Github actions in order to make them push the images to both DockerHub and ECR.
I also updated the release script and created the ECR Repo.

[arapulido]

Thanks for working on this! I added some comments and questions.

[tdimnet]

Thank you @arapulido for your review.
What did you have in mind for the release section?

By the way, I should also update the doc to let people know about ECR?

[arapulido]

There is an image name that has changed its name

[arapulido]

What did you have in mind for the release section?

what do you mean by this?

[arapulido]

LGTM! 🚀

[stanleegoodspeed]

Hi @tdimnet , what AWS account owns these ECR repositories?

[tdimnet]

Hey @stanleegoodspeed!

I send you the name of the account via Slack.

---

And then, I'll merge this PR, it's been open for so long.

[stanleegoodspeed]

• I confirmed that the github workflows can push to the new ECR registries under the dd-marketing account in addition to the existing repos in Dockerhub (tested against the nginx workflow + repos)
• I confirmed that the images can be pulled as expected from ECR using the following docker compose service definition running locally:

 nginx:
    restart: always
    image: public.ecr.aws/x2b9z2t7/ddtraining/nginx:latest
    ports:
      - "80:80"
    depends_on:
      - frontend
    labels:
      com.datadoghq.ad.logs: '[{"source": "nginx", "service": "nginx"}]'

Remaining Question

• traffic-replay is not included in the current release workflow and therefore has not been included in the new workflow. Is that intended?

[burningion]

I comment on some (but not all!) places where the dockerhub pushes were occuring. Let's ensure we're only pushing the the ECR registry with our automated builds.