Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Github Action for Advertisements #49

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

martinisoft
Copy link
Contributor

This is my first pass at a Github action that will build and publish the Advertisements service container to the Github Container Registry. For now, it will publish just a latest tag which we currently do to the Docker Hub registry. We can tackle versioning at another time.

I am putting my own access token here for now until they can support organizational level access tokens for publishing to this repo.

Relates to #47

@martinisoft martinisoft self-assigned this Nov 10, 2020
@martinisoft martinisoft force-pushed the aaron.kalin/github_action_advertisements branch from 4344a93 to 8c9a228 Compare November 10, 2020 23:07
Copy link
Collaborator

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two versions of the ads-service (ads-service, broken with some sleeps), and ads-service-fixed(with the removal of the sleeps). Can we duplicate this github action to also cover the second one?

@martinisoft
Copy link
Contributor Author

There are two versions of the ads-service (ads-service, broken with some sleeps), and ads-service-fixed(with the removal of the sleeps). Can we duplicate this github action to also cover the second one?

Sure thing. To simplify things down the road we could maybe make that bug a ENV driven feature flag so we're not duplicating efforts everywhere.

@arapulido
Copy link
Collaborator

There are two versions of the ads-service (ads-service, broken with some sleeps), and ads-service-fixed(with the removal of the sleeps). Can we duplicate this github action to also cover the second one?

Sure thing. To simplify things down the road we could maybe make that bug a ENV driven feature flag so we're not duplicating efforts everywhere.

Indeed, all the different versions of the application is a maintenance nightmare

@martinisoft
Copy link
Contributor Author

There are two versions of the ads-service (ads-service, broken with some sleeps), and ads-service-fixed(with the removal of the sleeps). Can we duplicate this github action to also cover the second one?

Sure thing. To simplify things down the road we could maybe make that bug a ENV driven feature flag so we're not duplicating efforts everywhere.

Indeed, all the different versions of the application is a maintenance nightmare

I have pushed a new commit and re-requested review

Aaron Kalin and others added 3 commits November 24, 2020 14:58
This is my first pass at a Github action that will build and publish the Advertisements service container to the Github Container Registry.

I am putting my own access token here for now until they can support organizational level access tokens for publishing to this repo.
We should eventually not do this and just use ENV feature flags.
Starting simple with latest tag until we figure out how versioning will
go
@martinisoft martinisoft force-pushed the aaron.kalin/github_action_advertisements branch from cd6734c to 73ce68b Compare November 24, 2020 20:58
@burningion burningion merged commit abefffc into master Nov 24, 2020
@burningion burningion deleted the aaron.kalin/github_action_advertisements branch November 24, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants