fix: avoid empty reason when auto-pausing canary #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 62.28% 62.31% +0.03%
==========================================
Files 41 41
Lines 2166 2168 +2
==========================================
+ Hits 1349 1351 +2
Misses 711 711
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
celenechang
reviewed
Nov 29, 2021
| @@ -142,7 +142,9 @@ func HighestRestartCount(pod *v1.Pod) (int, datadoghqv1alpha1.ExtendedDaemonSetS | |||
| restartCount = s.RestartCount | |||
| reason = datadoghqv1alpha1.ExtendedDaemonSetStatusReasonUnknown | |||
| if s.LastTerminationState != (v1.ContainerState{}) && *s.LastTerminationState.Terminated != (v1.ContainerStateTerminated{}) { | |||
| reason = datadoghqv1alpha1.ExtendedDaemonSetStatusReason(s.LastTerminationState.Terminated.Reason) | |||
| if s.LastTerminationState.Terminated.Reason != "" { // The Reason field is optional and can be empty | |||
celenechang
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HighestRestartCountandMostRecentRestartcannotStartReasonsset:Motivation
Make the canary auto-pause more reliable
Describe your test plan
InvalidImageNameis the easiest option to reproduce: