-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable profiling after logging setup #135
Conversation
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 62.37% 62.28% -0.10%
==========================================
Files 41 41
Lines 2169 2169
==========================================
- Hits 1353 1351 -2
- Misses 711 712 +1
- Partials 105 106 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
What does this PR do?
Configure the logger before calling
setupLog
.Motivation
This branch was logging before the logger was setup
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Make sure this line
Starting datadog profiler
is logged correctly when profiling is enabled