Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable profiling after logging setup #135

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Configure the logger before calling setupLog.

Motivation

This branch was logging before the logger was setup

	if ddProfilingEnabled {
		setupLog.Info("Starting datadog profiler")
...
	}

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Make sure this line Starting datadog profiler is logged correctly when profiling is enabled

@ahmed-mez ahmed-mez added bug Something isn't working component/controller labels Dec 6, 2021
@ahmed-mez ahmed-mez added this to the v0.8 milestone Dec 6, 2021
@ahmed-mez ahmed-mez requested a review from a team as a code owner December 6, 2021 12:12
@codecov-commenter
Copy link

Codecov Report

Merging #135 (8f77551) into main (f98add8) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   62.37%   62.28%   -0.10%     
==========================================
  Files          41       41              
  Lines        2169     2169              
==========================================
- Hits         1353     1351       -2     
- Misses        711      712       +1     
- Partials      105      106       +1     
Flag Coverage Δ
unittests 62.28% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/extendeddaemonsetreplicaset/controller.go 55.23% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98add8...8f77551. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants