Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ERS status update after canary unpause #137

Merged
merged 2 commits into from
Dec 7, 2021
Merged

fix: ERS status update after canary unpause #137

merged 2 commits into from
Dec 7, 2021

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Dec 7, 2021 •
edited
Loading

What does this PR do?

Update canary-pause condition in ExtendedDaemonsetReplicaSet status when an ERS has been validated after it was on pause.

Motivation

Fix status report on ERS and EDS for canary-pause condition.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Deploy an EDS and update it to have a canary deployment:

  • pause the canary with kubectl eds canary pause <eds-name> command
  • check the status of the ERS and EDS. they should have a canary-pause condition with status true.
  • validate directly the EDS with kubectl eds canary validate <eds-name>.

validation:

  • check the status of the ERS, the canary-pause condition status should be false now.
  • check the status of the EDS, the canary-pause condition status should be false now.

@clamoriniere clamoriniere requested a review from a team as a code owner December 7, 2021 10:11
github-actions[bot]
github-actions bot requested changes Dec 7, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere added the bug Something isn't working label Dec 7, 2021
@clamoriniere clamoriniere added this to the v0.8 milestone Dec 7, 2021
github-actions[bot]
github-actions bot approved these changes Dec 7, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Dec 7, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Dec 7, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere clamoriniere merged commit 6b43766 into main Dec 7, 2021
@clamoriniere clamoriniere deleted the clamoriniere/fix-conditions-false-status branch December 7, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez ahmed-mez approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component/controller
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clamoriniere @ahmed-mez