Update manager field #160
Merged
Update manager field #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage ? 63.22%
=======================================
Files ? 41
Lines ? 3073
Branches ? 0
=======================================
Hits ? 1943
Misses ? 1014
Partials ? 116
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
fanny-jiang
commented
May 15, 2023
fanny-jiang
force-pushed
the
fanny/CONTECO-16/update-mgr-field
branch
from
0f65096
to
60175b7
Compare
CharlyF
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Configure a controller manager name,
eds-controllerfor the manager managedField.Motivation
Previously, the
ExtendedDaemonSetresource created by the ExtendedDaemonset controller had the managed field,Manager: manager, which was ambiguous and confusing.This change customizes the Manager name to a more meaningful name,
eds-controller.Additional Notes
This change also updates the
Managerfield in the ExtendedReplicaSet toeds-controller.Describe your test plan
ExtendedDaemonSetmanifest fileMetadata.Managed Fields.Manageriseds-controller