Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EDSS ref on related Pod's labels #183

Merged
merged 2 commits into from
May 10, 2024
Merged

feat: add EDSS ref on related Pod's labels #183

merged 2 commits into from
May 10, 2024

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

Add 2 new labels on pods when they are linked to an ExtendedDaemonsetSettings resource.

  • extendeddaemonsetsetting.datadoghq.com/name
  • extendeddaemonsetsetting.datadoghq.com/namespace

Motivation

the goal is to allow pods filtering by ExtendedDaemonsetSettings name/ns.

Additional Notes

We use Labels and not annotations because we would like to be able to do pods query filtering like

kubectl get pod -l extendeddaemonsetsetting.datadoghq.com/name=foo -l extendeddaemonsetsetting.datadoghq.com/namespace=bar

Describe your test plan

Deploy an EDS and EDSS resource. on the pods linked to the EDSS the Pod labels should contains the 2 new labels.

@clamoriniere
feat: add EDSS ref on related Pod's labels
6d27f9e 
the goal is to allow pod filtering by ExtendedDaemonsetSettings name/ns.
@clamoriniere clamoriniere requested review from a team as code owners May 8, 2024 14:19
github-actions[bot]
github-actions bot requested changes May 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation, tooling

@fanny-jiang fanny-jiang added the enhancement New feature or request label May 8, 2024
github-actions[bot]
github-actions bot approved these changes May 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere clamoriniere added this to the v0.10 milestone May 9, 2024
github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

❌ MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #devflow with those details!

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2024

🚨 MergeQueue

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • repository configuration requires approval by code owners, but no code owner approved this PR
Details

Error: PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-7bf8f9d97d-cbcdx@): PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@dd-devflow
Copy link

dd-devflow bot commented May 10, 2024

❌ MergeQueue

Tests failed on this commit e8164b2

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

If you need support, contact us on Slack #devflow with those details!

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 10, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@dd-devflow
Copy link

dd-devflow bot commented May 10, 2024

🚨 MergeQueue

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • repository configuration requires approval by code owners, but no code owner approved this PR
Details

Error: PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-6959cd9c66-pl5tx@): PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere clamoriniere merged commit 2915602 into main May 10, 2024
63 of 64 checks passed
@clamoriniere clamoriniere deleted the clamoriniere/add-edss-name-on-pod-labels branch May 10, 2024 13:28
levan-m pushed a commit that referenced this pull request May 14, 2024
@clamoriniere @levan-m
feat: add EDSS ref on related Pod's labels (#183)
14ca65c 
the goal is to allow pod filtering by ExtendedDaemonsetSettings name/ns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request mergequeue-status: error qa/skip-qa
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clamoriniere @fanny-jiang