Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the CRDs of the chart to a dedicated directory #36

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Move the CRDs of the chart to a dedicated directory #36

merged 1 commit into from
Oct 4, 2020

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Sep 4, 2020

@L3n41c L3n41c added this to the v0.2 milestone Sep 4, 2020
@L3n41c L3n41c requested a review from a team as a code owner September 4, 2020 10:44
github-actions[bot]
github-actions bot requested changes Sep 4, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

github-actions[bot]
github-actions bot requested changes Sep 4, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@L3n41c L3n41c added the enhancement New feature or request label Sep 4, 2020
github-actions[bot]
github-actions bot approved these changes Sep 4, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   34.31%   34.31%           
=======================================
  Files          24       24           
  Lines        1658     1658           
=======================================
  Hits          569      569           
  Misses       1013     1013           
  Partials       76       76
Flag Coverage Δ
#unittests 34.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86c0c2...4454014. Read the comment docs.

clamoriniere
clamoriniere reviewed Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it works for helm2?

If not, we should add a readme.md in chart to explain the limitation: Helm2 not supported

@clamoriniere clamoriniere merged commit dfa892e into master Oct 4, 2020
@clamoriniere clamoriniere deleted the lenaic/chart_crds branch October 4, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
component/chart enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@L3n41c @codecov-commenter @clamoriniere