Allow the EDS to deploy pods on unschedulable nodes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
L3n41c
force-pushed
the
lenaic/unschedulable_nodes
branch
from
00b143b
to
8329734
Compare
L3n41c
force-pushed
the
lenaic/unschedulable_nodes
branch
from
8329734
to
f2a1a27
Compare
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 36.80% 37.46% +0.66%
==========================================
Files 29 29
Lines 1508 1500 -8
==========================================
+ Hits 555 562 +7
+ Misses 879 865 -14
+ Partials 74 73 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
L3n41c
force-pushed
the
lenaic/unschedulable_nodes
branch
from
72d1398
to
cc8f353
Compare
|
We should be able to test this in E2E tests by building Nodes with custom taints. |
L3n41c
force-pushed
the
lenaic/unschedulable_nodes
branch
from
cc8f353
to
f1b4b02
Compare
vboulineau
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the
ExtendedDaemonSetcontroller to deploy pods on unschedulable nodes.Motivation
Have the same behaviour as with the regular Kubernetes
DaemonSet.https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#taints-and-tolerations
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Cordon a node and check that the EDS controller still deploy a pod on it.