Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart configuration #44

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Oct 2, 2020

What does this PR do?

Update helm chart deployment:

  • update container argument to match new process args introduced with the operator-sdk v1.0.0 migration.
  • update liveness probe configuration and remove readiness problem.
  • update metrics port.

Motivation

Update the helm chart to be compatible with the new extendeddaemonset controller process.

Additional Notes

I used kustomize config that is now used for testing as reference: https://github.com/DataDog/extendeddaemonset/blob/master/config/manager/manager.yaml

Describe your test plan

Build the extendeddaemonset docker image from master HEAD, or with RC image. deploy the extendeddaemonset controller with the helm chart. the controller should start properly.

@clamoriniere clamoriniere added the bug Something isn't working label Oct 2, 2020
@clamoriniere clamoriniere added this to the v0.3 milestone Oct 2, 2020
@clamoriniere clamoriniere requested a review from a team as a code owner October 2, 2020 11:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   37.46%   37.46%           
=======================================
  Files          29       29           
  Lines        1500     1500           
=======================================
  Hits          562      562           
  Misses        865      865           
  Partials       73       73           
Flag Coverage Δ
#unittests 37.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae25ec7...82b7c22. Read the comment docs.

@clamoriniere clamoriniere merged commit 1a4fcc0 into master Oct 2, 2020
@clamoriniere clamoriniere deleted the clamoriniere/fix-chart-configuration branch October 4, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants