Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix leader election configmap name #47

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

  • fix name of leader-election's configmap
  • Update chart version.
  • Update docker tag in helm chart.
  • Update golang version.
  • Add back examples folder.

Motivation

Helm chart regression detected during QA.

Additional Notes

Describe your test plan

Deploy the EDS-controller with the helm chart. Check logs to validate that
leader-election configmap RBAC error is not present.

* fix name of leader-election's configmap
* Update chart version.
* Update docker tag in helm chart.
* Update golang version
@clamoriniere clamoriniere requested a review from a team as a code owner October 4, 2020 14:29
@clamoriniere clamoriniere added the bug Something isn't working label Oct 4, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere modified the milestones: v0.3, v0.2 Oct 4, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

Codecov Report

Merging #47 into v0.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v0.3      #47   +/-   ##
=======================================
  Coverage   37.46%   37.46%           
=======================================
  Files          29       29           
  Lines        1500     1500           
=======================================
  Hits          562      562           
  Misses        865      865           
  Partials       73       73           
Flag Coverage Δ
#unittests 37.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e43d52...1859f03. Read the comment docs.

@clamoriniere clamoriniere merged commit 7a700d7 into v0.3 Oct 4, 2020
@clamoriniere clamoriniere deleted the clamoriniere/fix-chart branch October 4, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants