Add a canary pod label #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ahmed-mez
force-pushed
the
ahmed-mez/canary-pod-annotation
branch
from
b814fb7
to
2e6779a
Compare
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
Coverage ? 36.73%
=========================================
Files ? 29
Lines ? 1530
Branches ? 0
=========================================
Hits ? 562
Misses ? 895
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vboulineau
reviewed
Oct 22, 2020
ahmed-mez
force-pushed
the
ahmed-mez/canary-pod-annotation
branch
from
2e6779a
to
8c45c3f
Compare
celenechang
reviewed
Oct 22, 2020
vboulineau
approved these changes
Oct 22, 2020
celenechang
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the label
extendeddaemonsetreplicaset.datadoghq.com/canary=trueas canary pods labelMotivation
Ease monitoring canary pods
Describe your test plan
extendeddaemonsetreplicaset.datadoghq.com/canary=truelabel (k get po -l extendeddaemonsetreplicaset.datadoghq.com/canary=true)k eds canary validate <eds-name>k get po -l extendeddaemonsetreplicaset.datadoghq.com/canary=truemust returnNo resources found