Add extendeddaemonset-check helper #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
L3n41c
reviewed
Oct 26, 2020
L3n41c
approved these changes
Oct 26, 2020
* add new cmd binary: `check-eds` * add new `app-example` chart * update ci to deliver the `datadog/extendeddaemonset-check` container image
clamoriniere
force-pushed
the
clamoriniere/add-eds-check
branch
from
811b929
to
c74f099
Compare
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 37.46% 36.73% -0.74%
==========================================
Files 29 29
Lines 1500 1530 +30
==========================================
Hits 562 562
- Misses 865 895 +30
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add extendeddaemonset-check helper
check-edswhich can check when a EDS update is finished.app-examplechart: example of an application using theExtendedDaemonset.datadog/extendeddaemonset-checkcontainer image.Motivation
Helm3 is not able to know when the deployment of an application deployed with an
ExtendedDaemonsetis done.The new
datadog/extendeddaemonset-checkcan be used as helm3 test.Additional Notes
N/A
Describe your test plan
To test it, please follow the instruction in the
charts/app-example/README.md