Add canary paused / failed metrics #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
celenechang
approved these changes
Nov 2, 2020
|
Nice work 👍 |
|
worth keeping in mind that the |
clamoriniere
approved these changes
Nov 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 37.54% 36.65% -0.89%
==========================================
Files 29 29
Lines 1537 1574 +37
==========================================
Hits 577 577
- Misses 886 923 +37
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
eds_status_canary_pausedgauge metric to identify canary in paused state along with the reason.Adds a new
eds_status_canary_failedgauge metric to identify canary in failed state along with the reason.Motivation
Canary metrics
Describe your test plan
Check the metrics are exported correctly for canaries in active and paused state.